Repository navigation
ci: packaged programmer at @v1, built with the esptool version this build used - #7
Merged
Merged
Conversation
…uild used The packaging action follows its @v1 tag now (tracks releases without a change here each time) and packages the esptool version the build used (esp-cpp/esp-packaged-programmer-action#7): the flash arguments ESP-IDF generates follow the esptool it builds with, so the programmer must carry the same one. The build step records it into build/esptool_version.txt and the file travels in the build artifact, where the action reads it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFjjnq3XCTRAXENSxsCxJU
|
✅Static analysis result - no issues found! ✅ |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the packaging update that uses the build’s esptool version.
No open issues 🎉
What changed in this PR
Updates programmer packaging to use the build’s esptool version, keeping the packaged tool compatible with ESP-IDF’s generated flash arguments.
Changes:
- Records the esptool version after a successful build.
- Includes
build/esptool_version.txtin the build artifact for the packaging action to consume. - Switches the packaging action from
@v1.0.5to the moving@v1release tag.
| File | Description |
|---|---|
.github/workflows/package_main.yml |
Passes the build’s esptool version through the artifact and updates the packaging action reference. |
Review effort: Balanced
ESP-IDF Size Report for 'Template'
FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The packaging workflow follows
esp-cpp/esp-packaged-programmer-actionat@v1, which tracks releases without a change here each time, and hands it the esptool version the build used, which the action now packages (esp-cpp/esp-packaged-programmer-action#7): the flash arguments ESP-IDF generates intoflasher_args.jsonandflash_argsfollow the esptool it builds with (ESP-IDF 6.x uses esptool 5.x, whose options are spelled with dashes), so the packaged programmer must carry the same one. The build step records it with one extra command (python -m esptool version | tail -1 > build/esptool_version.txt) and the file travels in the build artifact; the action reads it from there.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01DFjjnq3XCTRAXENSxsCxJU